-
Notifications
You must be signed in to change notification settings - Fork 6
Update common.json - Allow logo elements to be anyOf #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
1f7cd1f
to
e4a14ba
Compare
Hey @kingthorin thanks for addressing this! Sorry, I'm busy with other stuff recently -- I'll review this tomorrow. |
@rudransh-shrivastava wanna try reviewing some code, I think you're familiar enough with the code base. No pressure, it's an optional one. |
@arkid15r sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I think the positive test required_properties.yaml
can be renamed, it sounds a little misleading now. We can also introduce 3 positive tests like large_only.yaml/large_property.yaml
.
I'll add these tests in a new PR after this is merged.
Just a small change:
@rudransh-shrivastava great point on the tests. I’m happy to add those (and address the sorting comment). I’ll update this shortly. |
@kingthorin thank you |
30ee7e5
to
d2d4e99
Compare
Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
d2d4e99
to
eed8b4e
Compare
I think this is good to go now. Let me know if you'd like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @kingthorin
@rudransh-shrivastava appreciate your help with the review
Fixes #21.
Since there was no further input I decided I was right 👼