-
Notifications
You must be signed in to change notification settings - Fork 9.2k
3.3: initialize for minor release 3.3.0 #5044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3.3-dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good @ralfhandl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR initializes the minor release 3.3.0 by bumping version numbers across the OpenAPI specification files and test cases. It prepares the codebase for the next version by updating version references from 3.2.x to 3.3.x throughout the project.
- Update all OpenAPI version references from 3.2.x to 3.3.x
- Bump schema validation patterns and URLs to use 3.3 namespace
- Update test cases and examples to reference version 3.3.0
Reviewed Changes
Copilot reviewed 62 out of 62 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
tests/schema/schema.test.mjs | Update test description and OpenAPI version in test fixture |
tests/schema/pass/*.yaml | Bump OpenAPI version in all passing test cases from 3.2.x to 3.3.x |
tests/schema/fail/*.yaml | Bump OpenAPI version in all failing test cases from 3.2.x to 3.3.x |
src/schemas/validation/schema.yaml | Update schema ID, description, version pattern, and all spec references to 3.3 |
src/schemas/validation/schema-base.yaml | Update schema base ID, description, and references to 3.3 |
src/schemas/validation/meta.yaml | Update meta schema ID and vocabulary reference to 3.3 |
src/schemas/validation/dialect.yaml | Update dialect ID, title, description, and vocabulary references to 3.3 |
src/oas.md | Update specification version to 3.3.0 and add version history entries |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good but I'm going to hold off approving until there is some explanation of the one instance of "3.3.1".
@@ -1,4 +1,4 @@ | |||
openapi: 3.2.1 | |||
openapi: 3.3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this file "3.3.1" but all the others are "3.3.0"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case also tests a non-zero patch version number in the OpenAPI field, which should pass validation with a 3.3 schema, and it does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it is acceptable to use non-existent patch version numbers? So "3.3.987" also validates? That seems odd.
But if that's the case, can we add a comment in the file to make that clear?
src/oas.md
fromversions/3.2.0.md
on themain
branch with empty historyThis PR's head branch was created with
scripts/start-release.sh
from