Fixes #27 #87
Open
Fixes #27 #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcalabro
commented
Oct 4, 2018
paulcalabro
commented
- Added params for the operating system major and minor version numbers. Together with the OS name, these determine an OS'uniqueness in Foreman and should probably do so here as well.
- Sorted the module args.
1.) Added params for the operating system major and minor version numbers. Together with the OS name, these determine an OS'uniqueness in Foreman and should probably do so here as well. 2.) Sorted the module args.
Nosmoht
reviewed
Oct 8, 2018
| operatingsystem=dict(type='str', required=True), | ||
| config_template=dict(type='str', required=True), | ||
| template_kind=dict(type='str', required=True), | ||
| major=dict(type='int', required=True), |
There was a problem hiding this comment.
Hui, required would make playbooks not passing the parameter invalid. Is it really necessary?
|
Could people please test the change. As 2 new parameters are required, all playbooks not passing the parameter would be invalid and need change. @paulcalabro thx for the fix ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.