Skip to content

Conversation

gwleuverink
Copy link
Contributor

This PR adds a docsearch input to the mobile nav

image

@HassanZahirnia
Copy link
Collaborator

Hey Willem! Thanks for asking for my input. This looks good but personally I'd prefer to have the search button on a separate row, instead of replacing the "Theme:" label. But with the new recently added menu items, we may not have enough vertical space to achieve that, on some mobile devices.

@gwleuverink
Copy link
Contributor Author

Thanks for checking it out Hassan 🙏🏻 This works at a minimum of 360px.

You're right it's pretty snug vertically with the new Login link when I add two rows (on iphone SE).

If another menu item is added down the line even with this on 1 row it wouldn't be enough space, and I don't think the container is scrollable right now.

What do you think is best?

@gwleuverink
Copy link
Contributor Author

I really don't have a preference either way. It's your design so you should have the say in this.

Whichever one we choose we should add a scroll container. Even now if I visit the site in landscape mode I can't reach the menu items on the bottom

Live site right now:

image

Not sure who would navigate a website in landscape though 😅 But the same issue will arise in portrait when we add one more menu item.

@HassanZahirnia
Copy link
Collaborator

Hmm then I think it might be best to use this opportunity to change the mobile menu layout. We lack space to fit all the new additions, and even more so in the future.

Do you mind if I commit changes in this PR? Or want to merge this and I can create a separate one

@gwleuverink
Copy link
Contributor Author

gwleuverink commented Oct 9, 2025

Not at all. Have at it

I can also have a stab at it if you are tight on time. Let me know 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants