-
-
Notifications
You must be signed in to change notification settings - Fork 82
add docsearch input to mobile nav #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hey Willem! Thanks for asking for my input. This looks good but personally I'd prefer to have the search button on a separate row, instead of replacing the "Theme:" label. But with the new recently added menu items, we may not have enough vertical space to achieve that, on some mobile devices. |
Thanks for checking it out Hassan 🙏🏻 This works at a minimum of 360px. You're right it's pretty snug vertically with the new If another menu item is added down the line even with this on 1 row it wouldn't be enough space, and I don't think the container is scrollable right now. What do you think is best? |
Hmm then I think it might be best to use this opportunity to change the mobile menu layout. We lack space to fit all the new additions, and even more so in the future. Do you mind if I commit changes in this PR? Or want to merge this and I can create a separate one |
Not at all. Have at it I can also have a stab at it if you are tight on time. Let me know 👍🏻 |
This PR adds a docsearch input to the mobile nav