Migrate from copies from external plugintemplate to git submodules #223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, JSONViewer includes files from plugintemplate directly copied into external/npp
This PR removes these copies and migrates these dependencies to git Submodules like all other existing dependencies
Updates cause by move to submodules:
\src\NppJsonViewer\plugintemplate
folder for ease of useas done in Docking_Dialogue_Interface alternative template mentioned in official How to develop a plugin
ExternalIncludePath
inNppJsonViewerCommon.props
to include newNppJsonViewer\plugintemplate
folder$(SolutionDir)..\external\npp;
->$(SolutionDir)NppJsonViewer\plugintemplate;
DockingFeature
subfolderUpdated in:
AboutDlg.h
,JsonViewDlg.h
,SettingsDlg.h
NPPJSONViewer.vcxproj
andNPPJSONViewer.vcxproj.filters
in lexicographical order (ignoring case)Moved
plugintemplate\
files to the bottom since they are not a direct part of main projectUpdates cause by plugintemplate update:
NPPM_ADDTOOLBARICON
withNPPM_ADDTOOLBARICON_FORDARKMODE
inNppJsonPlugin.cpp
reusing samem_hMenuIcon.hToolbarIcon
fortoolbarIconsWithDarkMode
for dark modeNPPM_GETENABLETHEMETEXTUREFUNC
with direct call toEnableThemeDialogTexture
inSettingsDlg.cpp
uxtheme.lib
asAdditionalDependencies
toNPPJSONViewer.vcxproj
to link newly addedEnableThemeDialogTexture
URLCtrl.h
andURLCtrl.cpp
References: