Skip to content

Conversation

rongtao12
Copy link
Contributor

For scenario 3, step 12, it should be "is" not "is not".

Custom Rule matching all traffic for the login page:
So the condition needs to be : is RequestUri contains /login

For scenario 3, step 12, it should be "is" not "is not".

 Custom Rule matching all traffic for the login page:
So the condition needs to be : is RequestUri contains /login
Copy link
Contributor

@rongtao12 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 233f96d:

✅ Validation status: passed

File Status Preview URL Details
articles/web-application-firewall/ag/rate-limiting-configure.md ✅Succeeded

For more details, please refer to the build report.

@ttorble ttorble requested a review from Copilot October 8, 2025 14:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects a documentation error in the rate-limiting configuration guide for Web Application Firewall. The change fixes step 12 in scenario 3, where the operation should be "Is" instead of "Is not" when configuring a custom rule to match traffic for the login page.

  • Fixed incorrect operation instruction from "Is not" to "Is" for RequestUri matching

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ttorble
Copy link
Contributor

ttorble commented Oct 8, 2025

@joeolerich

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Oct 8, 2025
Copy link
Contributor

@halkazwini halkazwini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rongtao12 for the correction!
Please accept this minor formatting correction (click Commit suggestion).

Co-authored-by: Hussein Al Kazwini <85655443+halkazwini@users.noreply.github.com>
@rongtao12
Copy link
Contributor Author

hi halkazwini , I have clicked on the commit suggestion.

Copy link
Contributor

Learn Build status updates of commit ba60cd2:

✅ Validation status: passed

File Status Preview URL Details
articles/web-application-firewall/ag/rate-limiting-configure.md ✅Succeeded

For more details, please refer to the build report.

@halkazwini
Copy link
Contributor

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @joeolerich

@v-dirichards v-dirichards merged commit 6771bf2 into MicrosoftDocs:main Oct 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants