-
Notifications
You must be signed in to change notification settings - Fork 21.8k
Update rate-limiting-configure.md #127704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For scenario 3, step 12, it should be "is" not "is not". Custom Rule matching all traffic for the login page: So the condition needs to be : is RequestUri contains /login
@rongtao12 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Learn Build status updates of commit 233f96d: ✅ Validation status: passed
For more details, please refer to the build report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR corrects a documentation error in the rate-limiting configuration guide for Web Application Firewall. The change fixes step 12 in scenario 3, where the operation should be "Is" instead of "Is not" when configuring a custom rule to match traffic for the login page.
- Fixed incorrect operation instruction from "Is not" to "Is" for RequestUri matching
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
articles/web-application-firewall/ag/rate-limiting-configure.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @rongtao12 for the correction!
Please accept this minor formatting correction (click Commit suggestion).
Co-authored-by: Hussein Al Kazwini <85655443+halkazwini@users.noreply.github.com>
hi halkazwini , I have clicked on the commit suggestion. |
Learn Build status updates of commit ba60cd2: ✅ Validation status: passed
For more details, please refer to the build report. |
#sign-off |
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @joeolerich |
For scenario 3, step 12, it should be "is" not "is not".
Custom Rule matching all traffic for the login page:
So the condition needs to be : is RequestUri contains /login