[fix] auto-replenish: infinite loops #5715
Merged
+12
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/meteordevelopment/meteorclient/systems/modules/player/AutoReplenish.java
Show resolved
Hide resolved
src/main/java/meteordevelopment/meteorclient/systems/modules/player/AutoReplenish.java
Outdated
Show resolved
Hide resolved
|
another example of how writing code this late results in silly things |
src/main/java/meteordevelopment/meteorclient/systems/modules/player/AutoReplenish.java
Show resolved
Hide resolved
|
Replenishing items in your offhand is completely broken because it passes '9' as the slot index for the offhand. Apart from that this looks good. |
|
that's a bug inherited from the original code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
removes two different sources of infinite loops
Related issues
fixes #5714
How Has This Been Tested?
auto-replenish still works, and infinite loops do not (although the hotbar-to-hotbar loop was always very hard to trigger in the first place)
Checklist: