Skip to content

Unify socials with marketing web #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Unify socials with marketing web #686

wants to merge 4 commits into from

Conversation

harminius
Copy link
Contributor

@harminius harminius commented Oct 2, 2025 •
edited
Loading

Fixes: #679

  1. Unify social icons with the marketing web. Add missing socials, rm twitter.
  2. Replace paths with .svg files.
  3. External SVGs loaded via <img> cannot be styled with dynamic currentColor, so we inline SVGs by importing them as raw strings
  4. Github removed from the top banner
image

MarcelGeo
MarcelGeo requested changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@MarcelGeo MarcelGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it's ok to use html injecting here.

  • please try to build this branch on dev.merginmaps.com/docs with pipeline and see if everyting is ok by build.

src/.vitepress/theme/components/SocialIconsLink.vue Outdated
/>
</svg>
</span>
<a :href="href" target="_blank" rel="noopener">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave aria-label here

@harminius harminius changed the title Draft: Add missing socials, rm twitter Unify socials with marketing web Oct 2, 2025
@MarcelGeo
Copy link
Contributor

MarcelGeo commented Oct 2, 2025 •
edited
Loading

I see that logo of mergin maps is not visible if dark mode.

@harminius
Copy link
Contributor Author

I see that logo of mergin maps is not visible if dark mode.

probably some bad cache/loading

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelGeo MarcelGeo MarcelGeo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify social links icons with marketing web merginmaps.com
2 participants
@harminius @MarcelGeo