Skip to content

Fix: the vulnerability in ZoomedScene.__init__(..) where zoomed_camera_image_mobject_config cannot be configured #4442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: the vulnerability in ZoomedScene.__init__(..) where zoomed_camera_image_mobject_config cannot be configured #4442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecc68b2
fix: the vulnerability in ZoomedScene.__init__(..) where zoomed_camer…
MuRongxin Oct 15, 2025
8e02b7b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions manim/mobject/types/image_mobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,6 @@ def __init__(
default_display_frame_config = {
"stroke_width": 3,
"stroke_color": WHITE,
"buff": 0,
}
self.default_display_frame_config = default_display_frame_config
self.pixel_array = self.camera.pixel_array
Expand All @@ -325,9 +324,9 @@ def get_pixel_array(self):
return self.pixel_array

def add_display_frame(self, **kwargs: Any) -> Self:
config = dict(self.default_display_frame_config)
config = self.default_display_frame_config
config.update(kwargs)
self.display_frame = SurroundingRectangle(self, **config)
self.display_frame = SurroundingRectangle(self, buff=0, **config)
self.add(self.display_frame)
return self

Expand Down
4 changes: 2 additions & 2 deletions manim/scene/zoomed_scene.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def __init__(
"default_frame_stroke_width": 2,
"background_opacity": 1,
},
zoomed_camera_image_mobject_config: dict[str, Any] = {},
zoomed_camera_image_mobject_config: dict[str, Any] = None,
zoomed_camera_frame_starting_position: Point3DLike = ORIGIN,
zoom_factor: float = 0.15,
image_frame_stroke_width: float = 3,
Expand Down Expand Up @@ -115,7 +115,7 @@ def setup(self) -> None:
# Initialize camera and display
zoomed_camera = MovingCamera(**self.zoomed_camera_config)
zoomed_display = ImageMobjectFromCamera(
zoomed_camera, **self.zoomed_camera_image_mobject_config
zoomed_camera, self.zoomed_camera_image_mobject_config
)
zoomed_display.add_display_frame()
for mob in zoomed_camera.frame, zoomed_display:
Expand Down
Loading