Use real latest checkpoint in training #2564
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzjalen
changed the title
|
@FabianIsensee please review it. As for me I always have to rename checkpoint if I stopped it before. |
|
Hey I would prefer this logic would not use the file modification time as this can be flawed. If you want to make this logic more intelligent, please load the checkpoints and pick the one with the highest epoch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for issue: #2563
Instead of loading the latest checkpoint when the flag
--cis handled, we will filter to get the most recent checkpoint. This could be the latest, best, or final checkpoint.