Use dep: prefix to remove implicit feature flags #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's unlikely to be causing an issue in practice but that would be a breaking change, so for v11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request updates the project to use the
dep:prefix.By using the
dep:prefix, it removes the implicit feature flags that are automatically enabled by optional dependencies.For more details about the
dep:prefix, see https://doc.rust-lang.org/cargo/reference/features.html#optional-dependencies.If these implicit feature flags were intentional, this Pull Request is not appropriate and should be closed.
If they were not, merging this Pull Request will ensure that only explicitly defined feature flags are provided.