Enhanced String.replaceWithArgs to support non-positional format
#5347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryqwe
force-pushed
the
resources-single-parameter
branch
from
bcaba8a to
b0ce03d
Compare
…ecifiers (%s, %d) when only one argument is provided
henryqwe
force-pushed
the
resources-single-parameter
branch
from
b0ce03d to
3ea093f
Compare
harrytmthy
reviewed
Sep 21, 2025
| ) | ||
| } | ||
| } | ||
| args[index] |
There was a problem hiding this comment.
If a placeholder index exceeds the number of provided args (e.g. %3$s with only 2 args), this will throw IndexOutOfBoundsException. Would it be worth catching that and throwing a clearer error (similar to MissingFormatArgumentException) so devs can quickly see which placeholder is invalid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced
String.replaceWithArgsto support non-positional format specifiers (%s, %d) when only one argument is providedCMP-8385
Testing
Unit tests added