Skip to content

Conversation

npanpaliya
Copy link

No description provided.

@npanpaliya npanpaliya requested a review from kdrodger as a code owner January 24, 2024 10:00
Nishidha Panpaliya and others added 9 commits January 24, 2024 21:28
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
…ilable on Amazon Linux 2

Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
Copy link
Contributor

@kdrodger kdrodger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm told by Andrew and Irina that this still being reviewed and is not quite ready to go, not least of all because it contains a number of file headers which say that they are IBM confidential material, which of course would not belong here. I have been reassured by them that this was just a simple cut'n'paste error and that the contents are not actually confidential, but the PR will need to be cleaned up first anyway.

@npanpaliya
Copy link
Author

I'm told by Andrew and Irina that this still being reviewed and is not quite ready to go, not least of all because it contains a number of file headers which say that they are IBM confidential material, which of course would not belong here. I have been reassured by them that this was just a simple cut'n'paste error and that the contents are not actually confidential, but the PR will need to be cleaned up first anyway.

Yes, I'm correcting these and these are copy/paste errors.

Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
@npanpaliya
Copy link
Author

@kdrodger @memmertoIBM - I've corrected the copyright info in all the source files. Also addressed the other comments regarding AWS libraries/version and README update.
Thank you for the review and please let me know if you've further comments.

@npanpaliya
Copy link
Author

There is just one issue left to be fixed which I'm working on. It is in the src/Makefile.

Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
@npanpaliya
Copy link
Author

There is just one issue left to be fixed which I'm working on. It is in the src/Makefile.

This issue is fixed too.

@kdrodger @memmertoIBM - Request you to review this PR.

Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
@kdrodger
Copy link
Contributor

kdrodger commented Apr 2, 2024

Is this ready to be considered for merging now @npanpaliya @memmertoIBM . It's fine if not, I just wanted to confirm. Thanks.

@npanpaliya
Copy link
Author

Is this ready to be considered for merging now @npanpaliya @memmertoIBM . It's fine if not, I just wanted to confirm. Thanks.

I'm no more part of this project. Please reach out to Andrew Hilden at IBM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants