Skip to content

Conversation

aoles
Copy link
Member

@aoles aoles commented Sep 26, 2025

Pull Request Checklist

  • 1. I have rebased the latest version of the main branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Fixes # .

Information about the changes

  • Key functionality added:
  • Reason for change:

Examples and reasons for differences between live ORS routes, and those generated from this pull request

Required changes to ors config (if applicable)

@aoles aoles changed the base branch from main to ci/fix_external_pr_checks_test September 26, 2025 09:40
@github-actions github-actions bot added the ci label Sep 26, 2025
@aoles aoles mentioned this pull request Sep 26, 2025
13 tasks
@aoles aoles force-pushed the ci/fix_external_pr_checks_test branch from 24ed114 to 122a85c Compare September 26, 2025 16:20
@aoles aoles force-pushed the ci/fix_external_prs branch from 030e670 to bf50010 Compare September 26, 2025 16:30
@aoles aoles changed the title ci: fix workflow runs for external PRs [testing - DO NOT MERGE] ci: testing workflows for external PRs [DO NOT MERGE] Sep 28, 2025
@github-actions github-actions bot added ci and removed ci labels Sep 28, 2025
@aoles aoles changed the base branch from ci/fix_external_pr_checks_test to main September 29, 2025 08:36
@github-actions github-actions bot added ci and removed ci labels Sep 29, 2025
@aoles aoles force-pushed the ci/fix_external_prs branch from bf50010 to 8c14eb2 Compare September 29, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant