Skip to content

Conversation

ozrendev
Copy link
Contributor

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #7625

Description

Adds Catppuccin theme with colors from https://catppuccin.com/palette/
All added colors are selectable options in the Theme drop-down menu

Screenshots

2025-08-26_09-42-32 2025-08-26_09-39-16

Testing

I have compared files changed/added and copied all changes from previous Catppuccin theme pull requests but with relevant Latte colors.
I have tested and selected all menus that I can think of and checked for correct contrast where appropriate.

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 26, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 26, 2025 08:21
Copy link
Member

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up all the unnecessary editor metadata in the svg files (refer the existing ones for correct examples) and sort the entries correctly, Latte comes after Frappe in the alphabet.

@absidue absidue added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Aug 27, 2025
auto-merge was automatically disabled August 28, 2025 06:15

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 28, 2025 06:15
auto-merge was automatically disabled August 28, 2025 06:24

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 28, 2025 06:24
@absidue absidue added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Aug 30, 2025
@ozrendev ozrendev requested a review from absidue September 2, 2025 20:15
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Sep 15, 2025
@ozrendev
Copy link
Contributor Author

I'm a bit stuck on this one. Most of the colors in the official Latte palette don't conform with WCAG and I don't see any way around this apart from drastically shifting the colors, which then really it wouldn't be the same palette. Do you have any suggestions or is this palette just not suitable for the project?

@efb4f5ff-1298-471a-8973-3d47447115dc

@kommunarr could you help out with this

@kommunarr
Copy link
Collaborator

I'm much savvier on digital accessibility than I am on the privy mores of the theming world, so I can't say for certain whether this was a missed consideration by the palette makers or a tacit understanding that certain other colors only be used against the base selectively for decorative flourish. In any case, I'd strongly recommend that any theme colors (primary/secondary) that don't have a sufficient color contrast with the base be removed.

@efb4f5ff-1298-471a-8973-3d47447115dc

We could also alter the colors but idk which one is the worser solution. Providing the users 2 out of the possible 14 colors or providing all but altered

@kommunarr
Copy link
Collaborator

I see your point, but there are two main issues to consider:

  1. Changing the hue of a color (e.g., a pastel color enough to contrast sufficiently with a light theme) is often so significant a transformation that it loses its original character & namesake.
  2. Any new shades of green, blue, etc. we create through such adjustment to meet the specifications of digital accessibility are guaranteed to converge as per the inherent limitations of the criteria. With our motley swathe of primary/secondary color themes available, our color chart already has great coverage of the underlying domain. It follows that new colors created through such a process will be altogether so similar as to barely warrant unique entries.

@efb4f5ff-1298-471a-8973-3d47447115dc

I understand.

I'd strongly recommend that any theme colors (primary/secondary) that don't have a sufficient color contrast with the base be removed.

Im in favor of this too.

@ozrendev
Copy link
Contributor Author

So then should I remove all but 3 of the colors? (CatppuccinLatteBlue can be modified slightly to achieve 4.5:1 score https://coolors.co/contrast-checker/1b63f3-eff1f5)

One scenario I'm confused about (not specific to this but generally speaking) is what's stopping the user from selecting a light theme and a poor contrasting main/second theme? Or this is fine because ultimately it's up to the user and not the theme defaults?

2025-09-21_19-47-22

@efb4f5ff-1298-471a-8973-3d47447115dc

One scenario I'm confused about (not specific to this but generally speaking) is what's stopping the user from selecting a light theme and a poor contrasting main/second theme?

Nothing. The only thing we can do is provide a good experience for the colors that come with the theme.

There are open issues that are related to this subject, see #3934 #6661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Catpuccin Latte Theme
4 participants