-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Catpuccin Latte Theme #7943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Add Catpuccin Latte Theme #7943
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clean up all the unnecessary editor metadata in the svg files (refer the existing ones for correct examples) and sort the entries correctly, Latte comes after Frappe in the alphabet.
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contrast issues should be solved:
- https://coolors.co/contrast-checker/dc8a78-eff1f5
- https://coolors.co/contrast-checker/dd7878-eff1f5
- https://coolors.co/contrast-checker/ea76cb-eff1f5
- https://coolors.co/contrast-checker/e64553-eff1f5
- https://coolors.co/contrast-checker/fe640b-eff1f5
- https://coolors.co/contrast-checker/df8e1d-eff1f5
- https://coolors.co/contrast-checker/40a02b-eff1f5
- https://coolors.co/contrast-checker/179299-eff1f5
- https://coolors.co/contrast-checker/04a5e5-eff1f5
- https://coolors.co/contrast-checker/209fb5-eff1f5
- https://coolors.co/contrast-checker/1e66f5-eff1f5
- https://coolors.co/contrast-checker/7287fd-eff1f5
I'm a bit stuck on this one. Most of the colors in the official Latte palette don't conform with WCAG and I don't see any way around this apart from drastically shifting the colors, which then really it wouldn't be the same palette. Do you have any suggestions or is this palette just not suitable for the project? |
@kommunarr could you help out with this |
I'm much savvier on digital accessibility than I am on the privy mores of the theming world, so I can't say for certain whether this was a missed consideration by the palette makers or a tacit understanding that certain other colors only be used against the base selectively for decorative flourish. In any case, I'd strongly recommend that any theme colors (primary/secondary) that don't have a sufficient color contrast with the base be removed. |
We could also alter the colors but idk which one is the worser solution. Providing the users 2 out of the possible 14 colors or providing all but altered |
I see your point, but there are two main issues to consider:
|
I understand.
Im in favor of this too. |
So then should I remove all but 3 of the colors? (CatppuccinLatteBlue can be modified slightly to achieve 4.5:1 score https://coolors.co/contrast-checker/1b63f3-eff1f5) One scenario I'm confused about (not specific to this but generally speaking) is what's stopping the user from selecting a light theme and a poor contrasting main/second theme? Or this is fine because ultimately it's up to the user and not the theme defaults? ![]() |
Nothing. The only thing we can do is provide a good experience for the colors that come with the theme. There are open issues that are related to this subject, see #3934 #6661 |
Pull Request Type
Related issue
closes #7625
Description
Adds Catppuccin theme with colors from https://catppuccin.com/palette/
All added colors are selectable options in the Theme drop-down menu
Screenshots
Testing
I have compared files changed/added and copied all changes from previous Catppuccin theme pull requests but with relevant Latte colors.
I have tested and selected all menus that I can think of and checked for correct contrast where appropriate.