Skip to content

Update shebang to use /usr/bin/env for portability #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Update shebang to use /usr/bin/env for portability #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1130840
Update shebang to use /usr/bin/env for portability
SZanko Dec 9, 2024
2e7e0bc
Change /bin/env bash to /usr/bin/env
SZanko Dec 9, 2024
2e65726
Add bash as an argument to /usr/bin/env
SZanko Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Stardrop/Assets/Stardrop.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
#!/bin/bash
#!/usr/bin/env bash
chmod u+x ./Internal
./Internal
6 changes: 3 additions & 3 deletions Stardrop/Utilities/External/SMAPI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,17 @@ public static ProcessStartInfo GetPrepareProcess(bool hideConsole)
var smapiInfo = new FileInfo(Pathing.GetSmapiPath());
if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux) is true)
{
arguments = $"-c \"SMAPI_MODS_PATH='{Pathing.GetSelectedModsFolderPath()}' '{Pathing.GetSmapiPath().Replace("StardewModdingAPI.dll", "StardewValley")}'\"";
arguments = $"bash -c \"SMAPI_MODS_PATH='{Pathing.GetSelectedModsFolderPath()}' '{Pathing.GetSmapiPath().Replace("StardewModdingAPI.dll", "StardewValley")}'\"";
}
else if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX) is true)
{
arguments = $"-c \"'{Pathing.GetSmapiPath().Replace("StardewModdingAPI.dll", "StardewModdingAPI")}' --mods-path '{Pathing.GetSelectedModsFolderPath()}'\"";
arguments = $"bash -c \"'{Pathing.GetSmapiPath().Replace("StardewModdingAPI.dll", "StardewModdingAPI")}' --mods-path '{Pathing.GetSelectedModsFolderPath()}'\"";
}

Program.helper.Log($"Starting SMAPI with the following arguments: {arguments}");
var processInfo = new ProcessStartInfo
{
FileName = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? smapiInfo.FullName : "/bin/bash",
FileName = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? smapiInfo.FullName : "/usr/bin/env",
Arguments = arguments,
WorkingDirectory = smapiInfo.DirectoryName,
RedirectStandardOutput = false,
Expand Down
6 changes: 3 additions & 3 deletions Stardrop/Views/MainWindow.axaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1328,8 +1328,8 @@ private async Task HandleStardropUpdateCheck(bool manualCheck = false)
string[] arguments = new string[] { $"chmod +x {scriptPath}", $"{scriptPath}" };
var processInfo = new ProcessStartInfo
{
FileName = "/bin/bash",
Arguments = $"-c \"{string.Join(" ; ", arguments)}\"",
FileName = "/usr/bin/env",
Arguments = $"bash -c \"{string.Join(" ; ", arguments)}\"",
CreateNoWindow = true,
UseShellExecute = false
};
Expand Down Expand Up @@ -2442,7 +2442,7 @@ private void CreateDirectoryJunctions(List<string> arguments)
// Prepare the process
var processInfo = new ProcessStartInfo
{
FileName = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? "cmd" : "/bin/bash",
FileName = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? "cmd" : "/usr/bin/env bash",
Arguments = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? $"/C {string.Join(" & ", arguments)}" : $"-c \"{string.Join(" ; ", arguments)}\"",
RedirectStandardOutput = true,
RedirectStandardError = true,
Expand Down