Skip to content

Feature caching fix #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 118 commits into
base: develop
Choose a base branch
from
Open

Feature caching fix #357

wants to merge 118 commits into from

Conversation

Pwhsky
Copy link
Collaborator

@Pwhsky Pwhsky commented Jul 3, 2025 •
edited
Loading

This small PR contains an added typecheck and _ID check as described in issue #352

@giovannivolpe
Update features.py
381630d
@giovannivolpe
Update features.py
c6132f4
@giovannivolpe
Update features.py
4b68ce1
@giovannivolpe
Update features.py
21044e8
@giovannivolpe
Update test_features.py
0f55b17
@giovannivolpe
Update features.py
017f21e
@giovannivolpe
Value
3e4a546 
Update test_features.py

Update features.py

Update test_features.py

Update features.py
@giovannivolpe
Update test_features.py
83bb491
@giovannivolpe
remove __gpu_compatible__
8851004
@giovannivolpe
Update features.py
c806cfd
@giovannivolpe
Update test_features.py
a1f71d7
@giovannivolpe
Update features.py
b1ca6ca
@giovannivolpe
Update test_features.py
0a78b0f
@giovannivolpe
Update aberrations.py
2ea065b
@giovannivolpe
Update optics.py
d1b8d34
@giovannivolpe
Update image.py
84fecbd
@giovannivolpe
Update holography.py
6eafa18
@giovannivolpe
Update features.py
addebc9
@giovannivolpe
Update features.py
15cdd3c
@giovannivolpe
Update test_features.py
ef06761
@giovannivolpe
Update features.py
c8b3df6
@giovannivolpe
Update test_features.py
17e3921
@giovannivolpe
Update features.py
83a3566
@giovannivolpe
Update test_features.py
158f247
@giovannivolpe
Update features.py
00533aa
@giovannivolpe
Update test_features.py
910dae0
@giovannivolpe
Update features.py
755e09b
@giovannivolpe
Update features.py
046b6e2
@giovannivolpe
Update features.py
0c83f7c
@giovannivolpe
Update features.py
b2da196
@Pwhsky Pwhsky requested review from BenjaminMidtvedt and cmanzo July 3, 2025 09:11
@Pwhsky
Uses input(_ID) instead of input.current_value(_ID)
e648f9f 
This fixed the issue of not being able to call the feature with ().
@giovannivolpe
Copy link
Member

It doesn't pass unit test. Strange behavior with test_statistic.test_broadcast_list(). Please, check carefully

Base automatically changed from gv/final/features to develop July 11, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmanzo cmanzo Awaiting requested review from cmanzo

@BenjaminMidtvedt BenjaminMidtvedt Awaiting requested review from BenjaminMidtvedt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pwhsky @giovannivolpe