Add deliver and retrieve package conditions to train schedules #8984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slightly hacky fix for trains eating all packages in a post box, by requiring a condition be met to get the package or deliver the package.
…livery check. Fixed leaving mail transfer early when checking if delivering packages. Minor optimization via storing the results of needing to deliver and package filters so we aren't checking for every carriage.
VoidLeech
added
pr type: fix
|
@Liquidize, this pull request is targeting the wrong branch. Pull requests should target the branch corresponding to the earliest supported Minecraft version unless the changes are specific to code that only exists for a newer Minecraft version. Please change the target branch, resolve any merge conflicts, and leave a message here so we can continue with the process of reviewing and merging this pull request. Thanks! |
VoidLeech
reviewed
Aug 3, 2025
| "create.schedule.condition.redstone_link.unpowered": "Not powered", | ||
| "create.schedule.condition.redstone_link_off": "Link Off", | ||
| "create.schedule.condition.redstone_link_on": "Link On", | ||
| "create.schedule.condition.retrieve_package": "Retrieve Packages", |
There was a problem hiding this comment.
Changes to localization should be left to crowdin.
Also, why does this lang change remove lines that aren't removed from the default/interface file? Are they no longer used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick, slightly messy fix for #7598.
It changes how the station pushes packages to the trains cargo. Two new schedule conditions have been added "Retrieve Package" and "Deliver Package".
If the train is utilizing a schedule (e.g: not player controlled), when it stops at a station packages will not be automatically taken from the postboxes. This will only happen if "Fetch Package" destination instruction is used, or if the current destination entry has the new condition "Retrieve Package". In either case the filter is respected so it will not transfer packages to the train that do not match. Multiple "Retrieve Package" conditions can be used to stack package filters, in case * is too extreme.
Similarly a "Deliver Package" condition has been added, and when a train stops at a destination, it will only off load packages if the condition is present, or if deliver package instruction was used.
If the train is player controlled, the original functionality is used, as in it will eat all packages and deliver matching packages.
This can probably be done more optimally, but I really wanted it fixed for my own use and figured there's no harm in sharing it.