Skip to content

Conversation

ivokub
Copy link
Collaborator

@ivokub ivokub commented Sep 10, 2025

Description

Update gnark-crypto dependency and regenerate tinyfield implementation to avoid CI failures due to dirty tree after generation.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub requested a review from gbotrel September 10, 2025 12:27
@ivokub ivokub self-assigned this Sep 10, 2025
@ivokub ivokub marked this pull request as draft September 10, 2025 13:13
@gbotrel
Copy link
Collaborator

gbotrel commented Sep 10, 2025

was the bitReverse refactor needed because a linter complained the old one is marked Deprecated ?
Asking because I'm not a huge fan of having the package name being utils on gnark-crypto, was planning to revisit before doing a next release so we might have a tiny refactor to re-do.

@ivokub
Copy link
Collaborator Author

ivokub commented Sep 10, 2025

was the bitReverse refactor needed because a linter complained the old one is marked Deprecated ? Asking because I'm not a huge fan of having the package name being utils on gnark-crypto, was planning to revisit before doing a next release so we might have a tiny refactor to re-do.

Exactly! https://github.com/Consensys/gnark/actions/runs/17613708150/job/50041471329#step:7:29

I can also nolint tag it.

@ivokub
Copy link
Collaborator Author

ivokub commented Sep 10, 2025

And there is no big rush from my side. I wanted to merge Consensys/gnark-crypto#725, but then need #1601 on gnark side to fix some existing tests which assume gnark-crypto current behaviour. And that lead to linter errors which I wanted to fix in this PR.

But the initial issue is still imo great to merge - it allows for compatibility with other ecdsa libs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants