Skip to content

feat: GKR Add Instance #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 66 commits into
base: master
Choose a base branch
from
Open

feat: GKR Add Instance #1504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
609d47d
refactor: addInstance instead of series etc
Tabaie Jun 1, 2025
79d4cbf
feat: check for duplicate gates, allow limiting curves for gate
Tabaie Jun 1, 2025
82e33e5
refactor: gkr api tests
Tabaie Jun 1, 2025
ba06e5d
refactor gkr example
Tabaie Jun 1, 2025
700c152
refactor: solve hint called per instance
Tabaie Jun 2, 2025
30f5633
revert: newPrint back in std/gkr to avoid import cycle
Tabaie Jun 2, 2025
44d6b4c
refactor: remove circuit/instance rearranging
Tabaie Jun 2, 2025
f5f726c
chore: generify
Tabaie Jun 2, 2025
644fd6a
fix: registry duplicate detection
Tabaie Jun 2, 2025
2001e83
fix: solver hint id mismatch
Tabaie Jun 2, 2025
d3ca3c1
remove redundant make
Tabaie Jun 2, 2025
6474482
fix: works on plonk
Tabaie Jun 2, 2025
0c0b6b0
refactor: solve hint for test engine
Tabaie Jun 3, 2025
478d53d
fix prove hint
Tabaie Jun 3, 2025
6c83740
fix package tests
Tabaie Jun 3, 2025
d6e382f
refactor: remove println
Tabaie Jun 3, 2025
a8f30a4
chore: generify print removal
Tabaie Jun 3, 2025
8ac5f9f
feat: GetValue
Tabaie Jun 3, 2025
5bb879d
fix all gkrapi tests pass
Tabaie Jun 3, 2025
7f9a0f1
fix gkr-poseidon2
Tabaie Jun 3, 2025
355277c
Merge branch 'master' into feat/gkr/add-instance
Tabaie Jun 3, 2025
cfdb9d3
fix: reduce in test engine
Tabaie Jun 3, 2025
12788f3
fix: rename GkrCompressions -> GkrPermutations
Tabaie Jun 3, 2025
9a0bf0e
bench: gkrposeidon2
Tabaie Jun 3, 2025
618beff
fix pad for bls12377
Tabaie Jun 3, 2025
22b77f2
some more padding fixes
Tabaie Jun 3, 2025
250a35b
fix: padding issue in bn254
Tabaie Jun 4, 2025
1586760
chore generify fix
Tabaie Jun 4, 2025
e593d90
Let Uint64 panic
Tabaie Jun 4, 2025
9df619a
Update constraint/solver/gkrgates/registry.go
Tabaie Jun 4, 2025
8c88c52
refactor: use assert.EqualError
Tabaie Jun 4, 2025
f4d7aa8
Merge branch 'master' into feat/gkr/add-instance
Tabaie Jun 5, 2025
499ff52
refactor: import hash/all in test
Tabaie Jun 5, 2025
4ae9324
Merge branch 'master' into feat/gkr/add-instance
Tabaie Jun 6, 2025
4765d61
revert incorrect renaming
Tabaie Jun 8, 2025
b3d1af8
fix: use multicommitter
Tabaie Jun 10, 2025
31a0a59
fix: single instance and no instance edge cases
Tabaie Jun 11, 2025
db56157
fix: single-instance, circuit with depth
Tabaie Jun 11, 2025
b4544d6
Merge branch 'master' into feat/gkr/add-instance
Tabaie Jun 15, 2025
bdd01fd
Merge branch 'master' into feat/gkr/add-instance
Tabaie Jun 23, 2025
c170695
Merge branch 'master' into feat/gkr/add-instance
Tabaie Jul 2, 2025
70802ea
Merge branch 'master' into feat/gkr/add-instance
Tabaie Jul 7, 2025
4ca453c
docs: address cursor comments
Tabaie Jul 8, 2025
f2b1122
Merge branch 'master' into feat/gkr/add-instance
Tabaie Jul 9, 2025
b9c01be
Merge branch 'master' into feat/gkr/add-instance
Tabaie Jul 28, 2025
893ba91
Merge branch 'master' into feat/gkr/add-instance
Tabaie Aug 6, 2025
a13ac27
Merge branch 'master' into feat/gkr/add-instance
Tabaie Aug 19, 2025
8947d9f
refactor: remove MapRange
Tabaie Aug 19, 2025
4a09fd1
Merge branch 'master' into feat/gkr/add-instance
Tabaie Aug 28, 2025
929d732
Merge branch 'master' into feat/gkr/add-instance
Tabaie Sep 17, 2025
905d7c5
Merge branch 'master' into feat/gkr/add-instance
Tabaie Sep 29, 2025
b7107e4
style: public options
Tabaie Sep 29, 2025
67257dc
revert: Register to return an error only
Tabaie Sep 30, 2025
b1d61f1
fix: gate name conflict
Tabaie Sep 30, 2025
9971328
Merge branch 'master' into feat/gkr/add-instance
Tabaie Sep 30, 2025
99cf4a8
refactor: make `newSolvingDataOption` public
Tabaie Sep 30, 2025
5242279
docs: GKR Solver Hints
Tabaie Sep 30, 2025
af81887
Merge branch 'feat/gkr/add-instance' of https://github.com/Consensys/…
Tabaie Sep 30, 2025
c523fd2
refactor: effectuate PR feedback
Tabaie Oct 1, 2025
36784d6
build: go generate
Tabaie Oct 1, 2025
0ae0d21
refactor: don't use stored hint IDs
Tabaie Oct 1, 2025
82f2c9e
resolve some import cycles cause by hint reference
Tabaie Oct 1, 2025
26bbef6
feat: gkrhints package to avoid import cycle
Tabaie Oct 1, 2025
7e1c10f
Revert "resolve some import cycles cause by hint reference"
Tabaie Oct 1, 2025
a3d316e
refactor: don't record engine hint IDs
Tabaie Oct 1, 2025
61302f4
use nil pointer for function reference
Tabaie Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions constraint/bls12-377/solver.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions constraint/bls12-381/solver.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions constraint/bls24-315/solver.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions constraint/bls24-317/solver.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions constraint/bn254/solver.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions constraint/bw6-633/solver.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions constraint/bw6-761/solver.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading