Dev: rename 'Score' to 'Kind' #290
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the next iteration of renaming 'score' -> 'kind'.
Here we replace all occurences of the 'score' visible to
the user. So, an English version hawk will display all
correctly ('kind'). However
1) The part hidden from the user: backend, html and js tags,
etc. are still 'score'. Renaming those variables is an epic,
so maybe it's better not to touch them.
2) Renaming was mostly done automatically,
'Score of INFINITY' becomes 'Kind of INFINITY'
3) In the other languages the 'score' remains 'score'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next iteration of renaming
score->kind. Here we replace all occurences of thescorevisible to the user. So, an English version hawk will display all correctly (kind). Howeverscore. Changing those variables is an epic, so maybe it's better not to touch them.Score of INFINITYbecomesKind of INFINITY.