Add support for open generic type bindings in FilterConvention #8601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for binding open generic types to filter types in
FilterConvention
, addressing a limitation where you had to manually register every concrete generic type instance.Problem
Previously, the
BindRuntimeType
method only supported exact type matches. For generic types likeId<T>
, you were forced to bind each concrete implementation individually:This was non-ergonomic and defeated the purpose of generic types in C#.
Solution
Enhanced the
TryCreateFilterType
method inFilterConvention
to support open generic type bindings:The implementation directly addresses the core issue raised in #7082 - the inability to bind open generic types and the resulting need to manually register each concrete generic type instance.