Gsplat fixedframe transform #12926
Open
Gsplat fixedframe transform #12926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et has an identity root transform and children have their world transform
|
Thank you for the pull request, @keyboardspecialist! ✅ We can confirm we have a CLA on file for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue with tilesets that have an identity root transform and child tiles with their own world transform. This uses the tileset bounding sphere center point transformed using
Transforms.eastNorthUpToFixedFrame.Previously, because of the identity, it led to tiles transforming themselves into world space prematurely leading to low quality output due to precision loss.
Issue number and link
#12925
Testing plan
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change