Skip to content

Conversation

SGI-CAPP-AT2
Copy link
Collaborator

Description

Input is now provided so that user can input url to ccsync server

Fixes #392

An option should be there to input the API url directly, without recompiling the app.

Screenshots

RESULT

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

static const String _encryptionSecretKey = 'encryptionSecret';
static const String _clientIdKey = 'clientId';

static const String _apiUrlKey = 'championApiUrl';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that championApiUrl must be replaced with ccsyncBackendUrl, as it would be much more intuitive. championApi somewhat points towards the sync server instead

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

final TextEditingController _encryptionSecretController =
TextEditingController();
final TextEditingController _clientIdController = TextEditingController();
final TextEditingController _championApiUrlController = TextEditingController();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this to something like ccsyncBackendUrlController as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@its-me-abhishek its-me-abhishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make these changes

@SGI-CAPP-AT2
Copy link
Collaborator Author

SGI-CAPP-AT2 commented Jan 8, 2025

@its-me-abhishek do we have to change this placeholder/label? image

@its-me-abhishek
Copy link
Contributor

Yes, the naming should be done in reference to CCSync everywhere imo

Input is now provided so that user can input url to ccsync server
@SGI-CAPP-AT2
Copy link
Collaborator Author

@its-me-abhishek , I think this PR is ready to merge.
What do you think?

@its-me-abhishek
Copy link
Contributor

hey, I do not have the rights to merge in this repository and can only do such in CCSync. I think it can be merged though.

@SGI-CAPP-AT2
Copy link
Collaborator Author

Hey @Pavel401, please merge this PR. So that I can make #444 merge ready.

@Pavel401 Pavel401 merged commit 2353be9 into CCExtractor:main Feb 18, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add an option to enter API URL manually for CCSync

3 participants