feat: ccsync url input is added #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| static const String _encryptionSecretKey = 'encryptionSecret'; | ||
| static const String _clientIdKey = 'clientId'; | ||
|
|
||
| static const String _apiUrlKey = 'championApiUrl'; |
There was a problem hiding this comment.
I think that championApiUrl must be replaced with ccsyncBackendUrl, as it would be much more intuitive. championApi somewhat points towards the sync server instead
| final TextEditingController _encryptionSecretController = | ||
| TextEditingController(); | ||
| final TextEditingController _clientIdController = TextEditingController(); | ||
| final TextEditingController _championApiUrlController = TextEditingController(); |
There was a problem hiding this comment.
change this to something like ccsyncBackendUrlController as well
its-me-abhishek
suggested changes
Jan 8, 2025
|
@its-me-abhishek do we have to change this placeholder/label? |
|
Yes, the naming should be done in reference to CCSync everywhere imo |
Input is now provided so that user can input url to ccsync server
SGI-CAPP-AT2
force-pushed
the
add-api-url-manually-issue
branch
from
3af741a to
94447d3
Compare
1 task
|
@its-me-abhishek , I think this PR is ready to merge. |
|
hey, I do not have the rights to merge in this repository and can only do such in CCSync. I think it can be merged though. |
4 tasks
1 task
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Input is now provided so that user can input url to ccsync server
Fixes #392
Screenshots
Checklist