refactor(sdk-coin-apt): changes to convert argument by abi method #7205
+399
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivam-bitgo
force-pushed
the
COIN-5799-refactor-aptos-customtx-method
branch
from
b895e67 to
724566c
Compare
| /** | ||
| * Convert primitive argument values based on parameter type | ||
| */ | ||
| private convertPrimitiveArgument(arg: string | number | boolean, paramType: any): any { |
There was a problem hiding this comment.
can we have explicit types instead of any?
There was a problem hiding this comment.
have updated the return type
shivam-bitgo
force-pushed
the
COIN-5799-refactor-aptos-customtx-method
branch
from
724566c to
4226151
Compare
shivam-bitgo
changed the title
|
@claude please review |
kamleshmugdiya
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: COIN-5799