refactor: migrated generateWallet to typed routes #7052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielzhao122
force-pushed
the
WP-5415-express-migrate-api-v2-coin-wallet-generate-to-typed-routes
branch
from
16a0cd0 to
96dd8d5
Compare
| const coin = bitgo.coin(req.decoded.coin); | ||
| const result = await coin.wallets().generateWallet(req.body); | ||
| if (req.query.includeKeychains === 'false') { | ||
| if ((req.decoded.includeKeychains as any) === false) { |
There was a problem hiding this comment.
Why are we casting to any here?
There was a problem hiding this comment.
This is because includeKeychains is type BooleanFromString which has output type string so statically it is typed as a string but during runtime it is actually a boolean. I think this is because of how we setup the decoder.
Also includeKeychains is a parameter in the request and httpRequest requires that params are of type string
danielzhao122
force-pushed
the
WP-5415-express-migrate-api-v2-coin-wallet-generate-to-typed-routes
branch
from
fb1254e to
678e891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added keychain codecs to a general codec file, as I assume that these codecs could be reused (but not sure if they will). refactored the UT that covered generateWallet to ensure that encoding and decoding works e2e.
TICKET: WP-5415