Remove modern-isomorphic-ws as it's now included in Node.js 22.4.0+ without needing an experimental flag. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithout needing an experimental flag.
|
I think it's nice to have a fallback for older node versions |
|
I personally would prefer to use the built-in class but seeing as Node.js 20 is still being LTS supported this is a fair argument.
While I'm at it:
1.
Could you add @types/ws as an optional dependency? I tried uninstalling @types/ws from my project the other day and didn't realise that modern-isomorphic-ws didn't list it as a dependency (caused tsc to fail, lol).
2.
Would it be alright to provide a sort-of server-side API for the Neuro API? The Python SDK had this added recently and considering that most of the current Neuro API mock servers are built with TypeScript it could potentially be beneficial for this to have it as well.
|
|
Hm, I'll look into it when I'll have time |
Think I already have some pieces in place but I'll wait while you evaluate
we should thank you because it would've been so annoying to manually implement the API D: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yeah I didn't realise this either until today when I tried to install the package and it set a deprecation message.