Optimise session signing #881
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScreamingHawk
force-pushed
the
signing-optimisation
branch
from
836cdce to
a47decf
Compare
|
This PR needs a rebase and some love. Moving to draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Externally called functions call out for the most up to date wallet configuration, then internal functions pass around the retrieved details.
Reuse status internally for wallet when fresh status not required.
This PR also ensure the provider is using the correct chain id, and the passed wallet address matches that configured for the session manager. Fixes associated test implementations.
For the dapp client, do not check permissions for specific calls, this is done during signing only. Instead compare signer against the configuration. Also, reduce the number of calls to the session manager.