Update marketplace client #745
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtechVitek
reviewed
May 6, 2025
| createCurrencies(args: CreateCurrenciesArgs, headers?: object, signal?: AbortSignal): Promise<CreateCurrenciesReturn> | ||
| updateCurrency(args: UpdateCurrencyArgs, headers?: object, signal?: AbortSignal): Promise<UpdateCurrencyReturn> | ||
| listCurrencies(headers?: object, signal?: AbortSignal): Promise<ListCurrenciesReturn> | ||
| listCurrencies(args: ListCurrenciesArgs, headers?: object, signal?: AbortSignal): Promise<ListCurrenciesReturn> |
There was a problem hiding this comment.
@AlexanderKolberg hmm, is this technically a breaking change?
Should we always generate args: ListCurrenciesArgs no matter if there are any input arguments?
There was a problem hiding this comment.
"Technically" yes, but I can't imagine that anyone has used the other props.
But you have a very valid point, we should just had had a empty args object. But i guess we have to make it optional so it doest look so ugly listCurrencies({})
There was a problem hiding this comment.
yep, good idea on the optional arg
do you mind adding it to webrpc/gen-typescript?
args?: {}
vs.
args: ListCurrenciesArgs
right?
0xsequence-bot
force-pushed
the
update_marketplace_client
branch
from
ed17bfb to
8714316
Compare
0xsequence-bot
force-pushed
the
update_marketplace_client
branch
from
8714316 to
4013de6
Compare
0xsequence-bot
force-pushed
the
update_marketplace_client
branch
2 times, most recently
from
a2caa84 to
e937c96
Compare
0xsequence-bot
force-pushed
the
update_marketplace_client
branch
from
c38e2db to
34c42ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by https://github.com/0xsequence/marketplace-api/commit/c053fea4594384910a1577d8aa5cfcac10fce20d