Add ERC1155Holder to prevent Packs.reveal abuse #40
+887
−309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ERC1155Holder, which accepts ERC1155 tokens and allows them to be claimed by the claimant encoded in the data.
This prevents the user from denying certain tokens when interacting with
packs.reveal()
, which would allow them to retry for a better reveal.Includes some trivial optimizations to keep bytecode size within the limits.
This change does not require any ABI updates.
This includes NC-03, flipping the
_commitment
nested mapping keys.Future optimizations if we can reduce bytecode size further:
abi.encodePacked(recipient)
updateERC1155Holder()
to configure the holder after deployment