-
Notifications
You must be signed in to change notification settings - Fork 79
Open
Labels
help wantedExtra attention is neededExtra attention is needed
Description
For example,
fireorm/src/BaseFirestoreRepository.ts
Lines 23 to 28 in 2a98b9a
async findById(id: string) { | |
return this.firestoreColRef | |
.doc(id) | |
.get() | |
.then(d => (d.exists ? this.extractTFromDocSnap(d) : null)); | |
} |
Promise<T | null>
.However, if you check the
yarn build
generated lib/src/BaseFirestoreRepository.d.ts
, we will see Promise<T>
.
This is very unfortunate because it is giving up the benefit of the type itself.
The likely cause is that strictNullChecks
has been false
.
I tried to build with strictNullChecks
set to true, but I got 249 errors and found that I had to change a lot of this library.
Because of this situation, I think it is better to let the owner decide or fix the problem.
Metadata
Metadata
Assignees
Labels
help wantedExtra attention is neededExtra attention is needed