Unsaved changes modal shown when accessing document picker datatype

[bjarnef]

Which Umbraco version are you using?

16.2.0

Bug summary

I noticed when accessing ContentPicker datatype instance and then navigating to another node/datatype, the Unsaved changes modal is shown even though no changes has been made.

Pretty annoying when having several instances of document picker.

chrome_YNocOQkvaT.mp4

I also found the search a bit confusing as I was looking for the formerly known "Content Picker", but the new Content Picker is the formerly known MNTP, while Document Picker is the new name. However Document Picker use "Umbraco.ContentPicker" property editor 😅

Searching "mntp" or "multinode" also doesn't result in "Content Picker" = MNTP 😜

Now I think we are back at this discussion include meta/tags for property editors may be relevant as well: #15957

Specifics

No response

Steps to reproduce

Expected result / actual result

No response

[github-actions]

Hi there @bjarnef!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[nielslyngsoe]

Hi @bjarnef

Can you open Dev-Tools and let us know what it says in this log:

Everytime we show the 'Discard changes'-modal we now output the reasoning in a console.log().

The problem is most likely that a JS-property have switched position with another one — our comparinson is quite sensitive in that regards.

It also means it should technically be solved by saving it once, but I still find it interesting to investigate what difference is causing this.

Thanks

[bjarnef]

@nielslyngsoe okay, I tried to reproduce, but it seems to work correct now.

I was able to import Deploy revisions from a v13 to v16 site following these steps: umbraco/Umbraco.Deploy.Issues#282 (comment)

and adjust the custom registered "Button Picker" property editor.
It may be worth looking into this at some time (and possible label/value presets is something many property editors can benefits from) and in that case we most likely doesn't need this custom property editor.
#11084

and another thought regarding UI component: umbraco/Umbraco.UI#1186

I think the Color Picker (Approved ColorPicker) can benefits from this PR: umbraco/Umbraco.UI#1156

I got an error regarding the OEmbed property editor though - it seems property editor and property editor UI can't have same alias:
dawoe/OEmbed-Picker-Property-Editor#45