wip

freekmurze · freekmurze · commit 8ad2eaca530a · 2025-08-24T11:00:28.000+02:00
diff --git a/src/Support/TransformationRegistration.php b/src/Support/TransformationRegistration.php
@@ -28,7 +28,13 @@ public function getUrls(): Generator
         foreach ($this->urls as $url) {
             $url = $url instanceof Closure ? ($url)() : $url;
 
-            yield $url;
+            if (! is_array($url)) {
+                $url = [$url];
+            }
+
+            foreach ($url as $singleUrl) {
+                yield $singleUrl;
+            }
         }
     }
 
diff --git a/tests/Actions/FetchUrlContentActionTest.php b/tests/Actions/FetchUrlContentActionTest.php
@@ -26,7 +26,6 @@
 });
 
 it('can be overridden with custom implementation', function () {
-    // Create a custom implementation
     $customAction = new class extends FetchUrlContentAction
     {
         public function execute(string $url): string
@@ -39,35 +38,3 @@ public function execute(string $url): string
 
     expect($content)->toBe('custom content for https://example.com');
 });
-
-it('is used by ProcessRegistrationAction via config', function () {
-    Http::fake([
-        'https://example.com' => Http::response('<html><body>Config test</body></html>', 200),
-    ]);
-
-    // The ProcessRegistrationAction should use the configured action
-    $processAction = new \Spatie\LaravelUrlAiTransformer\Actions\ProcessRegistrationAction;
-
-    // Use reflection to test the protected method
-    $reflection = new ReflectionClass($processAction);
-    $method = $reflection->getMethod('fetchUrlContent');
-    $method->setAccessible(true);
-
-    $content = $method->invoke($processAction, 'https://example.com');
-
-    expect($content)->toBe('<html><body>Config test</body></html>');
-});
-
-it('can handle large content', function () {
-    $largeContent = str_repeat('Lorem ipsum dolor sit amet. ', 10000);
-
-    Http::fake([
-        'https://example.com' => Http::response($largeContent, 200),
-    ]);
-
-    $action = new FetchUrlContentAction;
-    $content = $action->execute('https://example.com');
-
-    expect($content)->toBe($largeContent);
-    expect(strlen($content))->toBeGreaterThan(100000);
-});
diff --git a/tests/Support/TransformTest.php b/tests/Support/TransformTest.php
@@ -48,7 +48,7 @@
     expect($urls)->toBe(['https://example.com/', 'https://another.com/']);
 });
 
-it('can register urls using closures', function () {
+it('can register urls using closures that return a single url', function () {
     Transform::urls(
         fn () => 'https://example.com/',
         'https://another.com/',
@@ -66,6 +66,22 @@
     expect($urls)->toBe(['https://example.com/', 'https://another.com/', 'https://third.com/']);
 });
 
+it('can register urls using closures that return an array of urls', function () {
+    Transform::urls(
+        fn() => ['https://example.com/', 'https://another.com/']
+    )->usingTransformers(new TestTransformer);
+
+    $registrations = app(RegisteredTransformations::class)->all();
+
+    expect($registrations)->toHaveCount(1);
+
+    /** @var \Spatie\LaravelUrlAiTransformer\Support\TransformationRegistration $registration */
+    $registration = $registrations[0];
+    $urls = iterator_to_array($registration->getUrls());
+
+    expect($urls)->toBe(['https://example.com/', 'https://another.com/']);
+});
+
 it('can register multiple transformations separately', function () {
     Transform::urls('https://example.com/')
         ->usingTransformers(new TestTransformer);

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,13 @@ public function getUrls(): Generator`
`28`	`28`	`foreach ($this->urls as $url) {`
`29`	`29`	`$url = $url instanceof Closure ? ($url)() : $url;`
`30`	`30`
`31`		`- yield $url;`
	`31`	`+ if (! is_array($url)) {`
	`32`	`+ $url = [$url];`
	`33`	`+ }`
	`34`	`+`
	`35`	`+ foreach ($url as $singleUrl) {`
	`36`	`+ yield $singleUrl;`
	`37`	`+ }`
`32`	`38`	`}`
`33`	`39`	`}`
`34`	`40`