From 46c23468244ddb66f71e49dfcb5485687aca3d2f Mon Sep 17 00:00:00 2001 From: Saurav Kumar Date: Thu, 21 Aug 2025 18:07:55 +0530 Subject: [PATCH] fix(): fixing memory leak in keys-source-task --- .../kafka/connect/source/RedisKeysSourceTask.java | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/core/redis-kafka-connect/src/main/java/com/redis/kafka/connect/source/RedisKeysSourceTask.java b/core/redis-kafka-connect/src/main/java/com/redis/kafka/connect/source/RedisKeysSourceTask.java index 39857ae..76600a5 100644 --- a/core/redis-kafka-connect/src/main/java/com/redis/kafka/connect/source/RedisKeysSourceTask.java +++ b/core/redis-kafka-connect/src/main/java/com/redis/kafka/connect/source/RedisKeysSourceTask.java @@ -41,11 +41,6 @@ public class RedisKeysSourceTask extends SourceTask { public static final Schema KEY_SCHEMA = Schema.STRING_SCHEMA; - /** - * The offsets that have been processed and that are to be acknowledged by the - * reader in {@link RedisKeysSourceTask#commit()}. - */ - private final List> sourceOffsets = new ArrayList<>(); private final ToStructFunction converter = new ToStructFunction(); private final Clock clock; @@ -96,17 +91,10 @@ public void start(Map props) { } } - private void addSourceOffset(Map sourceOffset) { - sourceOffsets.add(sourceOffset); - } - @Deprecated @Override public void commitRecord(SourceRecord sourceRecord) throws InterruptedException { - Map currentOffset = sourceRecord.sourceOffset(); - if (currentOffset != null) { - addSourceOffset(currentOffset); - } + // do nothing - offset tracking not needed for Redis key monitoring } @Override