Add rule set for existing plugins

[joethei]

For example plugin and command ID's should not be changed in plugins that have already been approved, because that would break existing setups for users.

[4Source]

The trusted source here would be community-plugins.json correct?

I think best way to check this would be to fetch this file and compare the id for the entry with the same repository URL (not sure where to get this on the plugin side).

I think for the plugin developer it would be a nice to have if there is also a rule which checks if selected id is already in use by a plugin with a different repository URL in the community-plugins.json I think the effort to implement both would not be this much more.

About the command ID's why would this break for existing setups?

[joethei]

About the command ID's why would this break for existing setups?

Changing the command id will reset custom hotkeys / the mobile toolbar that might have been configured by the user

[4Source]

I imagine this could be kind of hard to check only thing I can imagine at the moment is using git to compare with previous releases.

But I think it should still be possibel to remove a command completely and also add new commands.

[joethei]

Don't overcomplicate it.
Plugin dev's will be recommended to use the recommended rule set if they are currently working on a new plugin.
Plugin's that are already in the list will be recommended to use the rule set related to this issue.

It's up to the plugin dev to decide which ruleset to use, they are not forced to use this even.
It's just a helper for development.
(The ReviewBot will still use the rules implemented in this plugin for new submissions though)

[4Source]

Here the different use cases I can see. If this isn't the behavior expected from this rules than I don't understand what it should be.

Recommended rules

Rule	new Submitted plugin	existing plugin*	Comment
Plugin ID unchanged	can't be applied	error	It is not possible to check if the id has changed if the plugin is not approved
Command ID's unchanged	warning	warning

*It is assumed that the plugin developer will continue to use the recommended rules after the plugin has been approved.

Plugin ID unchanged

What to compare it with: The reference would be community-plugins.json this contains the approved id of the plugin.

What to test: The plugin should have the same ID in manifest as in reference.

Command ID's unchanged

What to compare it with: The reference to compare the commands against would most likely be the previous release because this contains the ID's from the Commands the users are used to.

How to test: Compare the commands existing in the latest release with the current commands. The ID should be unchanged if the same command is detected. Removing ID's should be possible. Adding new ID's should be possible.