Improve Vector constructor error message (#1343)

Author: MaxAake

packages/core/src/vector.ts

@@ -61,16 +61,8 @@ export default class Vector<K extends Float32Array | Float64Array | Int8Array |
       this._type = vectorTypes.FLOAT32
     } else if (typedArray instanceof Float64Array) {
       this._type = vectorTypes.FLOAT64
-    } else if (
-      typedArray instanceof Uint8Array ||
-      typedArray instanceof Uint16Array ||
-      typedArray instanceof Uint32Array ||
-      typedArray instanceof BigUint64Array
-    ) {
-      throw newError('The neo4j Vector class does not support Unsigned Integer Arrays, please use a signed IntArray')
     } else {
-      // @ts-expect-error
-      throw newError(`The neo4j Vector class is a wrapper for TypedArrays. got ${(typedArray.toString() as string)}`)
+      throw newError(`Invalid argument type passed to Vector constructor: should be signed integer or float TypedArray, got: ${(typedArray as any)?.constructor?.name as string ?? 'undefined or type without constructor name'}`)
     }
     this._typedArray = typedArray
   }
@@ -132,15 +124,7 @@ export function vector<K extends Float32Array | Float64Array | Int8Array | Int16
   try {
     return new Vector(typedArray)
   } catch {
-    if (
-      typedArray instanceof Uint8Array ||
-      typedArray instanceof Uint16Array ||
-      typedArray instanceof Uint32Array ||
-      typedArray instanceof BigUint64Array
-    ) {
-      throw newError('Invalid argument type passed to vector constructor function: should be signed integer or float TypedArray, got unsigned integer TypedArray')
-    }
-    throw newError(`Invalid argument type passed to vector constructor function: should be TypedArray, got ${typedArray.toString()}`)
+    throw newError(`Invalid argument type passed to vector constructor function: should be signed integer or float TypedArray, got: ${typedArray?.constructor?.name ?? 'undefined or type without constructor name'}`)
   }
 }
 

packages/core/test/vector-type.test.ts

@@ -33,8 +33,9 @@ describe('Vector', () => {
     })
 
     it.each([
-      ['array', [], 'should be TypedArray, got'],
-      ['Unsigned TypedArray', Uint16Array.from([]), 'should be signed integer or float TypedArray, got unsigned integer TypedArray']
+      ['array', [], 'Invalid argument type passed to vector constructor function: should be signed integer or float TypedArray, got: Array'],
+      ['Unsigned TypedArray', Uint16Array.from([]), 'Invalid argument type passed to vector constructor function: should be signed integer or float TypedArray, got: Uint16Array'],
+      ['undefined', undefined, 'Invalid argument type passed to vector constructor function: should be signed integer or float TypedArray, got: undefined or type without constructor name']
     ])('should fail to create create vector from (%s)', (_, typedArray, expectedMessage) => {
       // @ts-expect-error
       expect(() => vector(typedArray)).toThrow(expectedMessage)