GameSettings.java declaration mixup

[SeasonalFerret]

From #4, new issue for tracking reasons.

Issue is reproduceable with new installation of mcp1.8.9op after running setup.bat
setup.bat output: https://hastebin.com/share/ifesorokoc.vbnet

[dxxxxy]

Everything is kinda shifted. The mappings are likely messed up although this shouldn't happen unless Minecraft's source code has been updated (or the source isn't official).

You can see the difficulty field is a Minecraft object and EnumDifficulty is further down below. Same thing for Keybinding, it's shifted by one position in order.

[SeasonalFerret]

Did you manage to reproduce this yourself?

[SeasonalFerret]

May be caused by public boolean hideGUI;, as this line does not appear in my GameSettings.java and some stuff is oddly shifted

[SeasonalFerret]

There's also " private static final String __OBFID = "CL_00000650";" that fails to appear, which coincidentally happens to be where the shifting stops.
I'm unsure if it's related, but both this line and hideGUI don't appear to be referenced anywhere else.

It's taken a while, but I've manually fixed my source.

[dxxxxy]

I've managed to reproduce the error, but it was working before because I have an old project with the correct fields.

It seems the first field had logger skipped over.

[dxxxxy]

@SylveonBottle I've investigated and found that it's actually because of Optifine, which means this error has been present for a long time now... I can't believe I never noticed it.

You can see it right here: https://github.com/DxxxxY/mcp1.8.9op/blob/master/op/net/minecraft/client/settings/GameSettings.java

[dxxxxy]

@SylveonBottle I could downgrade to the previous version which my old project used or you can paste your changes and open a pull request. I severely doubt that this happens in every file though...