Remember Me with 2FA Bug (and fix) #323
Description
Apologize if I'm doing this wrong. I don't really git.
I've been trying to figure out why the Remember Me option doesn't work when 2FA is enabled and it seems that there may be an error in Auth.php where the 2FA success is logged.
On line 967 when Auth>onLoginSuccessful is called, it also calls the parent function UserManager->onLoginSuccessful which sets the SESSION_FIELD_AWAITING_2FA_REMEMBER_DURATION value to null. The result is that on line 971 the value is no longer set and Auth->createRememberDirective does not run.
Switching the order in which the functions are called fixes the issue.