SQL Parser fails on SET TIME ZONE syntax

[mattsax]

Failed SQL

SET TIME ZONE 'UTC';
-- ERROR:  Unable to parse: ParserError("Expected equals sign or TO, found: ZONE")

Tool
This SQL was generated by Looker while trying to setup a connection, using Postgresql 9.5+ dialect.
It seems that Looker attempts to set the session time zone upon establishing a database connection.

Version:
v1.3

Additional context

I have manually tested several variations of the command. According to the official PostgreSQL documentation the following syntaxes are all valid:

SET TIME ZONE 'UTC';
-- ERROR:  Unable to parse: ParserError("Expected equals sign or TO, found: ZONE")
SET TIME ZONE TO 'UTC';
-- ERROR:  Unable to parse: ParserError("Expected equals sign or TO, found: ZONE")
SET TIMEZONE TO 'UTC';                                                                                                                                                                  
-- SET => This one works

[igorlukanin]

@mattsax Could you please explain what are you trying to achieve here? Why would you want Looker to connect to Cube's SQL API? 😄

[mattsax]

Hi @igorlukanin ,
We currently have several frontend tools exposing analytics data, Looker being one of them (for self-service purposes). We would like to have a single semantic layer for these tools. This would also enable a smooth transition from Looker to an alternative self-service tool in the future.

[florentcheneau]

Hi,

Apparently cube-js relies on https://github.com/cube-js/sqlparser-rs.git to parse SQL queries (specifically the cubesql-v0.16.0 branch, see requirements for the cubesql crate:

cube/rust/cubesql/cubesql/Cargo.toml

Line 20 in b279611

sqlparser = { git = 'https://github.com/cube-js/sqlparser-rs.git', rev = "e14d5bf45367edd8679cbc15ccee56693da8e4fb" }

).

The issue seems to be coming from this line: https://github.com/cube-js/sqlparser-rs/blob/e14d5bf45367edd8679cbc15ccee56693da8e4fb/src/parser.rs#L3771

Indeed, it expects to find a single word between the SET and TO keywords, hence the error message, and why it works with TIMEZONE but does not account for (yet valid) the TIME ZONE version.