feat: enforce requirement for at least one dependency attribute in Dependency class (#5472)

* feat: enforce requirement for at least one dependency attribute in Dependency class

Signed-off-by: Frost Ming <me@frostming.com>

* fix: simplify argument parsing in set_build_args function

Signed-off-by: Frost Ming <me@frostming.com>

---------

Signed-off-by: Frost Ming <me@frostming.com>

Author: frostming

src/_bentoml_sdk/service/dependency.py

@@ -35,6 +35,10 @@ class Dependency(t.Generic[T]):
     url: str | None = None
     _resolved: t.Any = attrs.field(default=None, init=False)
 
+    def __attrs_post_init__(self) -> None:
+        if self.on is None and self.url is None and self.deployment is None:
+            raise ValueError("Must specify at least one of on, deployment or url")
+
     @t.overload
     def get(self: Dependency[None]) -> RemoteProxy[t.Any]: ...
 

src/bentoml_cli/utils.py

@@ -495,13 +495,12 @@ def set_build_args(ctx: Context, param: Parameter, value: str | tuple[str]) -> N
         value = (value,)
     arguments: dict[str, str] = {}
     for item in value:
-        for part in item.split(","):
-            key, has_equal, val = part.partition("=")
-            if not has_equal:
-                raise click.BadParameter(
-                    f"Invalid argument format: {part}. Must be in the form of key=value"
-                )
-            arguments[key] = val
+        key, has_equal, val = item.partition("=")
+        if not has_equal:
+            raise click.BadParameter(
+                f"Invalid argument format: {item}. Must be in the form of key=value"
+            )
+        arguments[key] = val
 
     set_arguments(arguments, override=False)