Do not depend on rustfmt as a build dependency #1174
Description
I've searched existing issues and couldn't find a duplicate.
- I confirm this is not a duplicate.
Operating System
Windows 10
Server Software Version/Commit
What happened?
Because I had a minimal rust installation (just rustc and cargo), I did not install rustfmt. In pumpkin-data, rustfmt is used as a build dependency, requiring me to install components of the rust ecosystem I dont intend to use. This should either be removed or be made into a dev dependency instead.
To Reproduce
- Install minimal rust using rustup.
- Try compiling pumpkin
Expected behavior
It would compile instead of blurting out this error:
Compiling pumpkin-data v0.1.0-dev+1.21.8 (C:\Users\coreign\Desktop\Pumpkin\pumpkin-data)
error: failed to run custom build command for `pumpkin-data v0.1.0-dev+1.21.8 (C:\Users\coreign\Desktop\Pumpkin\pumpkin-data)`
Caused by:
process didn't exit successfully: `C:\Users\coreign\Desktop\Pumpkin\target\release\build\pumpkin-data-233b352793ba8a1b\build-script-build` (exit code: 101)
--- stdout
cargo:rerun-if-changed=../assets/chunk_status.json
cargo:rerun-if-changed=../assets/damage_type.json
cargo:rerun-if-changed=../assets/noise_parameters.json
cargo:rerun-if-changed=../assets/particles.json
cargo:rerun-if-changed=../assets/entity_pose.json
cargo:rerun-if-changed=../assets/world_event.json
cargo:rerun-if-changed=../assets/packets.json
cargo:rerun-if-changed=../assets/blocks.json
cargo:rerun-if-changed=../assets/bedrock_block_states.nbt
cargo:rerun-if-changed=../assets/properties.json
cargo:rerun-if-changed=../assets/screens.json
cargo:rerun-if-changed=../assets/scoreboard_display_slot.json
cargo:rerun-if-changed=../assets/game_rules.json
cargo:rerun-if-changed=../assets/biome.json
cargo:rerun-if-changed=../assets/multi_noise_biome_tree.json
cargo:rerun-if-changed=../assets/recipes.json
cargo:rerun-if-changed=../assets/entities.json
cargo:rerun-if-changed=../assets/sounds.json
cargo:rerun-if-changed=../assets/game_event.json
cargo:rerun-if-changed=../assets/tags.json
cargo:rerun-if-changed=../assets/blocks.json
cargo:rerun-if-changed=../assets/items.json
cargo:rerun-if-changed=../assets/biome.json
cargo:rerun-if-changed=../assets/fluids.json
cargo:rerun-if-changed=../assets/entities.json
cargo:rerun-if-changed=../assets/sound_category.json
cargo:rerun-if-changed=../assets/attributes.json
cargo:rerun-if-changed=../assets/fuels.json
cargo:rerun-if-changed=../assets/data_component.json
cargo:rerun-if-changed=../assets/fluids.json
cargo:rerun-if-changed=../assets/items.json
cargo:rerun-if-changed=../assets/message_type.json
cargo:rerun-if-changed=../assets/flower_pot_transformations.json
cargo:rerun-if-changed=../assets/composter_increase_chance.json
cargo:rerun-if-changed=../assets/entity_statuses.json
cargo:rerun-if-changed=../assets/potion.json
cargo:rerun-if-changed=../assets/spawn_egg.json
cargo:rerun-if-changed=../assets/enchantments.json
cargo:rerun-if-changed=../assets/potion_brewing.json
cargo:rerun-if-changed=../assets/effect.json
cargo:rerun-if-changed=../assets/density_function.json
cargo:rerun-if-changed=../assets/recipe_remainder.json
--- stderr
thread '<unnamed>' (18616) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread '<unnamed>' (18580) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18608) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18612) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18588) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18624) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18604) panicked at pumpkin-data\build\build.rs:145:10:
Failed to write to rustfmt stdin.: Os { code: 109, kind: BrokenPipe, message: "The pipe has been ended." }
thread '<unnamed>' (18576) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18596) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18600) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18572) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18584) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18628) panicked at pumpkin-data\build\build.rs:145:10:
Failed to write to rustfmt stdin.: Os { code: 109, kind: BrokenPipe, message: "The pipe has been ended." }
thread '<unnamed>' (18632) panicked at pumpkin-data\build\build.rs:145:10:
Failed to write to rustfmt stdin.: Os { code: 109, kind: BrokenPipe, message: "The pipe has been ended." }
thread '<unnamed>' (18624) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18580) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18596) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18576) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18600) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18572) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18604) panicked at pumpkin-data\build\build.rs:145:10:
Failed to write to rustfmt stdin.: Os { code: 109, kind: BrokenPipe, message: "The pipe has been ended." }
thread '<unnamed>' (18588) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18608) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18632) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18612) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18628) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18620) panicked at pumpkin-data\build\build.rs:145:10:
Failed to write to rustfmt stdin.: Os { code: 109, kind: BrokenPipe, message: "The pipe has been ended." }
thread '<unnamed>' (18584) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18616) panicked at pumpkin-data\build\build.rs:145:10:
Failed to write to rustfmt stdin.: Os { code: 109, kind: BrokenPipe, message: "The pipe has been ended." }
thread '<unnamed>' (18592) panicked at pumpkin-data\build\build.rs:145:10:
Failed to write to rustfmt stdin.: Os { code: 109, kind: BrokenPipe, message: "The pipe has been ended." }
thread '<unnamed>' (18624) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18580) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18576) panicked at pumpkin-data\build\build.rs:154:9:
rustfmt failed with status: exit code: 1
--- stderr ---
error: 'rustfmt.exe' is not installed for the toolchain 'nightly-x86_64-pc-windows-msvc'.
To install, run `rustup component add rustfmt`
thread '<unnamed>' (18596) panicked at pumpkin-data\build\build.rs:145:10:
Failed to write to rustfmt stdin.: Os { code: 109, kind: BrokenPipe, message: "The pipe has been ended." }