DCP injection not handling conditionals #190
Description
The current mechanism of injecting DCPs is problematic. Corrupts “requires” clause if there are conditional compilation expressions in it. The package can’t compile anymore after the corruption of the requires clause
More info on why I need conditionals at required clause is at (see issue description on SVGIconImageList from GetIt and last comments on CodeSite Express also from Getit) issue Delphi IDE has with adding filed to such packages (eats up the parts in the conditionals at the requires clause) https://embt.atlassian.net/servicedesk/customer/portal/1/RSS-2644
See my question on this at deepwiki:
https://deepwiki.com/search/the-regex-is-buggy-it-cant-han_21bbf50d-b047-413b-91dd-fcb512d503ff
The DCP injection is analyzed here:
https://deepwiki.com/HashLoad/boss/5.2-dcp-injection
The issue starts most probably with the regex used to parse the requires clause. Since BOSS can’t evaluate conditionals (unless it could ask delphi compiler to) it could at least leave parts in those unchanged, including keeping the conditionals in place