Skip to content

Resource Filenames need to be URI Encoded #1545

@dbouwman

Description

@dbouwman

PS logged a bug with the Hub team about a failure to convert a site to a template (aka a Solution). In our investigation we found that the issue was related to how Solution.js was fetching an image resource. The tldr is that file resource filenames can contain chars that are not valid in urls. e.g. the [ and ] in this filename AdobeStock_253484648%20[Converted].png. The fix is to call encodeURIComponent(...) on the filename before making the request to get it... which is here in Solution.js

I'm not sure this is the only place that this would need to be applied, but this is where I traced things back to.

Given how long this has been around, I don't think it's a high priority, but it looks like an easy fix

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions